Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE: modify maximum character of NIM #81

Merged
merged 2 commits into from
Sep 24, 2023

Conversation

vincentiusantu
Copy link
Collaborator

Hello devkom. Here I'm gonna explain some update.

Since the number of digit in the NIM of Telkom University students has changed to 12, so I changed the rules of number of digit in students' NIM on daskomweb.com. I put the examples of NIM and I change the max character from 10 to 12. And also I change the assistant code (DIP -> CEN) when there's something trouble about the website.

Copy link
Collaborator

@adhiiimf adhiiimf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall good. But I want to know what is the purpose of that port and is it safe to change the port? maybe @Soedipo still remember about that

resources/js/Pages/Login.vue Outdated Show resolved Hide resolved
Copy link
Collaborator

@Soedipo Soedipo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's been removed, then I approve it... Good Luck for the practicum!!!

@vincentiusantu vincentiusantu merged commit 30bd9ff into daskomdev:master Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants